The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		May 18, 2026 0:49am

PR Summary

Medium Risk
Touches shared filter SQL generation used by query/update/delete paths, so an incorrect cast or missing column metadata could change which rows are matched. Changes are scoped and covered by new unit tests for date casting behavior.

Overview
Fixes table row filtering for date-typed columns by threading column metadata into buildFilterClause and emitting ::timestamp casts for range operators ($gt/$gte/$lt/$lte) when the target column is type: 'date' (keeping ::numeric for number fields).

Updates API routes and service/tool call sites to pass schema.columns/table into filter building (including bulk deleteRowsByFilter), and expands SQL builder unit tests to assert the new casting behavior and guard numeric comparisons.

^{Reviewed by Cursor Bugbot for commit daa1047. Bugbot is set up for automated code reviews on this repo. Configure here.}

Greptile Summary

This PR fixes incorrect SQL casts for date column comparisons in the table filter query builder by threading column type metadata through buildFilterClause → buildFieldCondition → buildComparisonClause, emitting ::timestamp instead of ::numeric when the column type is 'date'.

• sql.ts: buildFilterClause gains an optional columns?: ColumnDefinition[] parameter; a columnTypeMap is derived from it and passed down to buildComparisonClause, which now uses ::timestamp for date columns and ::numeric otherwise.
• types.ts: $gt/$gte/$lt/$lte in ConditionOperators are widened from number to number | string to allow date strings.
• sql.test.ts: New date column type suite verifies ::timestamp is used for all four range operators, a combined range, an $and-nested filter, and a numeric regression guard.

Confidence Score: 3/5

The SQL builder change is logically correct, but the fix doesn't reach production because no call site passes the new columns argument — date filters will continue to fail at runtime.

Every real call site — both route handlers and all three service.ts call sites — omits the new columns argument. In both route handlers table.schema.columns is already in scope; in updateRowsByFilter the table parameter is received but its columns aren't forwarded. The unit tests pass because they explicitly supply columns, masking the gap. Merging as-is leaves the reported bug unfixed in all API-facing paths.

apps/sim/lib/table/service.ts (lines 1438, 1821, 2132) and both route handler files need the columns argument wired in before this fix has any effect in production.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["buildFilterClause(filter, tableName, columns?)"] --> B["Build columnTypeMap from columns"]
    B --> C{Field type?}
    C -->|"$or / $and"| D["buildLogicalClause(..., columns)"]
    D --> A
    C -->|"regular field"| E["buildFieldCondition(..., columnTypeMap.get(field))"]
    E --> F{Operator}
    F -->|"$gt/$gte/$lt/$lte"| G["buildComparisonClause(..., columnType?)"]
    G --> H{columnType === 'date'?}
    H -->|Yes| I["(data->>'field')::timestamp OP value::timestamp"]
    H -->|No| J["(data->>'field')::numeric OP value"]

_{Reviews (1): Last reviewed commit: "test: Update test for verify date column..." | Re-trigger Greptile}